Provider validate - don't attempt to directly connect from the UI #6237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miq-bot
changed the title
|
Cc @Hyperkid123 - FYI, this could be relevant with the provider form rewrite effort |
validation via the queue was added in #1580, but explicitly left some cases to try connecting directly. This is not really desirable as the UiWorker is not guaranteed to be able to do that in general.
|
Checked commit https://github.com/himdel/manageiq-ui-classic/commit/e92aa4c59498118e50c63e78a9de1733f80ce5d1 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
Tested:
(Not tested: containers (no credentials), networks (no credentials), configuration (provider down)) |
|
@miq-bot remove_label wip |
miq-bot
changed the title
mzazrivec
approved these changes
Oct 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
validation via the queue was added in #1580,
but explicitly left some cases to try connecting directly.
This is not really desirable as the UiWorker is not guaranteed to be able to do that in general.
@miq-bot add_label wip
we only talked about this with @agrare and @gprocunier on gitter September 24, 2019 8:30 PM,
I have not actually tested this with any (or all) providers.